Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused file internal/logger/logrus.go #1721

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

seiyab
Copy link
Contributor

@seiyab seiyab commented Feb 17, 2024

I encountered a problem reported in anchore/go-logger#13. When I tried to fix it, this misleading dead code confused me. This file looks to get unused at #1026 so I remove it to prevent confusion.

Signed-off-by: seiya <[email protected]>
Signed-off-by: seiya <[email protected]>
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @seiyab !

@kzantow kzantow added the changelog-ignore Don't include this issue in the release changelog label Feb 20, 2024
@kzantow kzantow merged commit 05953ea into anchore:main Feb 20, 2024
10 checks passed
@seiyab seiyab deleted the remove-unused-file branch February 20, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-ignore Don't include this issue in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants